[FE training-materials-updates] Kernel slides: misc corrections and improvements

Michael Opdenacker michael.opdenacker at free-electrons.com
Mon May 26 09:16:41 CEST 2014


Repository : git://git.free-electrons.com/training-materials.git

On branch  : master
Link       : http://git.free-electrons.com/training-materials/commit/?id=2469d9abe9971f14f0f8184503354d5c41e402f7

>---------------------------------------------------------------

commit 2469d9abe9971f14f0f8184503354d5c41e402f7
Author: Michael Opdenacker <michael.opdenacker at free-electrons.com>
Date:   Mon May 26 09:15:32 2014 +0200

    Kernel slides: misc corrections and improvements
    
    - Suggested by Robert P. J. Day (thanks!)
    
    Signed-off-by: Michael Opdenacker <michael.opdenacker at free-electrons.com>


>---------------------------------------------------------------

2469d9abe9971f14f0f8184503354d5c41e402f7
 slides/kernel-frameworks/kernel-frameworks.tex     |   12 +++++++-----
 .../kernel-misc-subsystem.tex                      |    2 +-
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/slides/kernel-frameworks/kernel-frameworks.tex b/slides/kernel-frameworks/kernel-frameworks.tex
index bca9c85..d1d2854 100644
--- a/slides/kernel-frameworks/kernel-frameworks.tex
+++ b/slides/kernel-frameworks/kernel-frameworks.tex
@@ -21,7 +21,7 @@
 \subsection{User space vision of devices}
 
 \begin{frame}
-  \frametitle{Types of devices} Under Linux, there is essentially
+  \frametitle{Types of devices} Under Linux, there are essentially
   three types of devices:
   \begin{itemize}
   \item {\bf Network devices}. They are represented as network
@@ -48,8 +48,8 @@
     device.
   \item The {\em minor number} typically indicates the number of the
     device (when they are for example several serial ports)
-  \item Major and minor numbers are statically allocated, and
-    identical accross all Linux systems.
+  \item Most major and minor numbers are statically allocated, and
+    identical across all Linux systems.
   \item They are defined in \kerneldoc{devices.txt}.
   \end{itemize}
 \end{frame}
@@ -155,6 +155,8 @@ close(fd);
     driver. All of them are optional.
   \end{itemize}
 \begin{minted}[fontsize=\footnotesize]{c}
+#include <linux/fs.h>
+
 struct file_operations {
     ssize_t (*read) (struct file *, char __user *,
         size_t, loff_t *);
@@ -200,7 +202,7 @@ struct file_operations {
 \begin{frame}
   \frametitle{read()}
   \begin{itemize}
-  \item \mint{c}+ssize_t foo_read(struct file *f, __user char *buf,+
+  \item \mint{c}+ssize_t foo_read(struct file *f, char __user *buf,+
     \mint{c}+size_t sz, loff_t *off)+
     \begin{itemize}
     \item Called when user space uses the \code{read()} system call on
@@ -221,7 +223,7 @@ struct file_operations {
   \frametitle{write()}
   \begin{itemize}
   \item \mint{c}+ssize_t foo_write(struct file *f,+
-    \mint{c}+__user const char *buf, size_t sz, loff_t *off)+
+    \mint{c}+const char __user *buf, size_t sz, loff_t *off)+
     \begin{itemize}
     \item Called when user space uses the \code{write()} system call
       on the device
diff --git a/slides/kernel-misc-subsystem/kernel-misc-subsystem.tex b/slides/kernel-misc-subsystem/kernel-misc-subsystem.tex
index 465ea45..1c8aa8f 100644
--- a/slides/kernel-misc-subsystem/kernel-misc-subsystem.tex
+++ b/slides/kernel-misc-subsystem/kernel-misc-subsystem.tex
@@ -37,7 +37,7 @@
 \begin{frame}[fragile]{Misc subsystem API (1/2)}
   \begin{itemize}
   \item The misc subsystem API mainly provides two functions, to
-    register and unregister one {\em misc device}:
+    register and unregister {\bf a single} {\em misc device}:
     \begin{itemize}
     \item \code{int misc_register(struct miscdevice * misc);}
     \item \code{int misc_deregister(struct miscdevice *misc);}



More information about the training-materials-updates mailing list