[bootlin/training-materials updates] master: slides/kernel-driver-development-modules: use octal value in module_param() (4b4aa09a)
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Tue Mar 26 09:13:11 CET 2019
Repository : https://github.com/bootlin/training-materials
On branch : master
Link : https://github.com/bootlin/training-materials/commit/4b4aa09a218e05c1a288ab0fe1739a6cc72b051e
>---------------------------------------------------------------
commit 4b4aa09a218e05c1a288ab0fe1739a6cc72b051e
Author: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Date: Tue Mar 26 09:13:11 2019 +0100
slides/kernel-driver-development-modules: use octal value in module_param()
checkpatch complains about the usage of S_IRUGO and recommends to use
octal values instead. The checkpatch message is:
Symbolic permissions '$oval' are not preferred. Consider using octal permissions '$octal'
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
>---------------------------------------------------------------
4b4aa09a218e05c1a288ab0fe1739a6cc72b051e
.../kernel-driver-development-modules.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slides/kernel-driver-development-modules/kernel-driver-development-modules.tex b/slides/kernel-driver-development-modules/kernel-driver-development-modules.tex
index d100780b..7a1a372e 100644
--- a/slides/kernel-driver-development-modules/kernel-driver-development-modules.tex
+++ b/slides/kernel-driver-development-modules/kernel-driver-development-modules.tex
@@ -327,7 +327,7 @@ module_param(
/* Example */
static int irq=5;
-module_param(irq, int, S_IRUGO);
+module_param(irq, int, 0644);
\end{minted}
Modules parameter arrays are also possible with
\kfunc{module_param_array}.
More information about the training-materials-updates
mailing list